fix: Add tag to SSM param to allow global access #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8 tasks
gabelton
reviewed
Aug 15, 2024
| @@ -56,6 +56,10 @@ run "aws_vpc_unit_test" { | |||
| error_message = "Should be: String" | |||
| } | |||
|
|
|||
| assert { | |||
| condition = aws_ssm_parameter.combined_nat_gateway_eips.tags.Copilot-application == "__all__" | |||
There was a problem hiding this comment.
Suggested change
| condition = aws_ssm_parameter.combined_nat_gateway_eips.tags.Copilot-application == "__all__" | |
| condition = aws_ssm_parameter.combined_nat_gateway_eips.tags.Copilot-application == "__all__" | |
| error message = "Should be: __all__" |
There was a problem hiding this comment.
Hard to get formatting right in github suggestion, but that's why codebuild terraform-tests is failing. And I think it needs tf lint or whatever running again
gabelton
reviewed
Sep 9, 2024
| @@ -116,7 +116,9 @@ resource "aws_ssm_parameter" "combined_nat_gateway_eips" { | |||
| name = "/${var.arg_name}/EGRESS_IPS" | |||
| type = "String" | |||
| value = join(",", local.nat_gateway_eips) | |||
| tags = local.tags | |||
| tags = merge(local.tags, { | |||
| Copilot-application = "__all__" | |||
There was a problem hiding this comment.
Should this be:
Suggested change
| Copilot-application = "__all__" | |
| copilot-application = "__all__" |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot services by default can only access SSM params tagged with the application and environment. An associated change has been made in platform-tools to allow services to access any SSM parameter tagged with
Copilot-application = "__all__"This PR adds the tag to the SSM parameter containing egress IPs for a given VPC.