Json support #2
Open
Json support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated some of the APIs to separate Simple & Derived Observations (to sidestep issue with XML->Java Object polymorphism issue - not accepting derived types with an base type param).
- body reader added to assist with conversion from observation to derived (XML->Java) - Helper exception handler to catch JAXB conversion errors (and others) - Simple "submit either Simple or Derived" observation
- Single API for observation added
# Conflicts: # src/main/java/org/uksrc/archive/ObservationResource.java # src/test/java/org/uksrc/archive/ObservationResourceTest.java
Updated XML examples for consistency with the JSON ones Removed the overkill object mapper for subtypes of observation
Integrated retrieving a subset of Observations based on a collections ID into a single function (either supply an id for a subset or not for all observations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for JSON (submission & response with request headers set etc.)
Separated Collections from Observations
Merged retrieval of Observations and Observations filtered by collection endpoint
Separated some utilities methods to reduce repeatability.
Added some more examples and documentation
A few new unit tests