Upserting capabilities added at creation #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljackson92
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This is good, but can we split this into two different commands: create and update.
- create: clears the database and then creates everything
- update: only attempts to insert (or update) the data.
I think this should just be added as a command line option to the script.
LariDG
requested review from
samueljackson92
and removed request for
jameshod5
| for grant_query in grant_privileges: | ||
| conn.execute(grant_query) | ||
|
|
||
| def create_or_upsert_table(self, table_name: str, df: pd.DataFrame): |
There was a problem hiding this comment.
Could we also have unit testing for this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a function that will upsert tables when making them in the create script. Instead of dropping the database if it exists each time the script now does an upsert (update or insert) using the on_conflict_do_update command from sqlalchemy. I have tested it by changing the data in the
\tests\mock_data\index\folder, initially only including half the shots, and then including all to see if the tables change as expected.What I am not sure about is in line 215
shot_metadata = shot_metadata.replace(np.nan, None)I have changed nan to None as I kept getting an error (psycopg2.errors.NumericValueOutOfRange: integer out of range) that column values were wrong for the schema and looking online it seems that Postgres doesn't equate nan to None. I am not sure why this doesn't break the previous version though as the schema and data is identical so I am a bit suspicious of this line.