Feat/t 100 keycloak authentication #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalsz
requested review from
samueljackson92,
NathanCummings,
LariDG and
jameshod5
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
8 times, most recently
from
1a5f96a to
ce1d7de
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
2 times, most recently
from
412a50d to
4fed944
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
from
d76f52f to
4ec723a
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
4 times, most recently
from
78f0e73 to
7c7a4ee
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
from
7c7a4ee to
c6fab43
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
from
226d2dc to
ec761d7
Compare
khalsz
force-pushed
the
feat/T-100-keycloak-authentication
branch
from
133c8e8 to
dbecc0d
Compare
| df.to_sql("shots", engine, if_exists="append", index=False) | ||
| return shot_data | ||
| except Exception as e: | ||
| raise HTTPException(status_code=400, detail=f"Error:{str(e)}") |
There was a problem hiding this comment.
Why are you masking the real exception and returning an HTTPException? Could this not become hard to debug if the exception is actually coming from pandas?
| df.to_sql("signals", engine, if_exists="append", index=False) | ||
| return signal_data | ||
| except Exception as e: | ||
| raise HTTPException(status_code=400, detail=f"Error:{str(e)}") |
| df.to_sql("cpf_summary", engine, if_exists="append", index=False) | ||
| return cpf_data | ||
| except Exception as e: | ||
| raise (HTTPException(status_code=400, detail=f"Error:{str(e)}")) |
|
A few questions from me:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers authentication/authorisation of fair-mast post api end based on user role (fair-mast-admin).
Below are demos.
image
image
image