Add level2 ingestion into repo #52
Open
+149,472
−112,903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stion into 51-level2-ingestion
|
This can be merged I guess? |
|
@NathanCummings no, James had one or two points that need to be updated. Also no one has reviewed this pr yet because it's still in draft! |
|
Sorry, swear I checked to see if it was draft or not 🤦♂️ |
|
Looks good to me. I have ingested and the data looks fine. Level2 has many less signals, although looking in the buckets and mappings this seems intentional? The documentation is slightly confusing, maybe need to be clearer about where the default ingestion is taking place. For "if running in csd3" section you could also put the metadata path. |
LariDG
reviewed
Feb 28, 2025
LariDG
reviewed
Feb 28, 2025
LariDG
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot be merged before #50
To test.
closes #51 #33 #53