Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: install type stubs #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FFY00
Copy link

@FFY00 FFY00 commented Sep 13, 2020

Signed-off-by: Filipe Laíns [email protected]

Signed-off-by: Filipe Laíns <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files           5        5           
  Lines        1057     1057           
=======================================
  Hits          948      948           
  Misses        109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be6458...06bcfe6. Read the comment docs.

@@ -16,6 +16,7 @@
author_email="[email protected]",
url="https://github.com/uiri/toml",
packages=['toml'],
package_data={"toml": ["__init__.pyi"]},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this more generic by doing a "*.pyi" as it is not out of the question, that more files will be created in the future.

@henryiii henryiii mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants