-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-task-zipper): optional parameter to turn absolute data sour… #1046
Conversation
…e paths into relative ones
Thanks for the review 😊 Ready to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more - I didn't see this in my check yesterday - but then we can merge!
@nicoschoenteich @petermuessig |
@petermuessig usually does the releases. Are we good to release? |
Sorry, I messed-up the release - should be available now |
@nicoschoenteich: shouldn't this be done before zipping so that the modified |
…ce paths into relative ones
I stumpled across this while working on the generator-ui5-project, where we want to turn absolute data sources paths into relative ones, to be able to deploy them to SAP Build Work Zone, standard edition. Currently the open-ux-tools (which both the generator-ui5-project and the Fiori Tools Application Generator rely on) only add absolute paths to the manifest, which is why this transformation is necessary.
I thought it makes sense to implement this here in a reusable manner instead of building a custom script for it.
This has been mentioned/requested before, see here: SAP/ui5-tooling#625