Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-task-zipper): optional parameter to turn absolute data sour… #1046

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

nicoschoenteich
Copy link
Contributor

…ce paths into relative ones

I stumpled across this while working on the generator-ui5-project, where we want to turn absolute data sources paths into relative ones, to be able to deploy them to SAP Build Work Zone, standard edition. Currently the open-ux-tools (which both the generator-ui5-project and the Fiori Tools Application Generator rely on) only add absolute paths to the manifest, which is why this transformation is necessary.

I thought it makes sense to implement this here in a reusable manner instead of building a custom script for it.

This has been mentioned/requested before, see here: SAP/ui5-tooling#625

@nicoschoenteich
Copy link
Contributor Author

Thanks for the review 😊 Ready to merge now?

Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more - I didn't see this in my check yesterday - but then we can merge!

packages/ui5-task-zipper/lib/zipper.js Outdated Show resolved Hide resolved
packages/ui5-task-zipper/test/zipper.test.js Show resolved Hide resolved
@petermuessig petermuessig merged commit f9ceb6d into ui5-community:main Aug 2, 2024
5 checks passed
@vc10812
Copy link

vc10812 commented Aug 6, 2024

@nicoschoenteich @petermuessig
The release action was skipped. When will the latest version be available from npm?

@nicoschoenteich
Copy link
Contributor Author

@petermuessig usually does the releases. Are we good to release?

@petermuessig
Copy link
Member

Sorry, I messed-up the release - should be available now

@vc10812 @nicoschoenteich

@norbip
Copy link

norbip commented Nov 26, 2024

@nicoschoenteich: shouldn't this be done before zipping so that the modified manifest.json gets into Component-preload.js as well? 🤔 In certain cases the embedded manifest gets priority where the absolute path remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants