Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize database using alembic migrations #258

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

raffomania
Copy link
Contributor

@raffomania raffomania commented Nov 24, 2023

Fixes #254

Since the new migration is skipped when the user table already exists, it should do nothing on existing production systems. On new development setups, migrations should now work fine.

I've updated the relevant section in the developer guide as well.

@raffomania raffomania self-assigned this Nov 24, 2023
@raffomania raffomania force-pushed the initialize-with-migrations branch 7 times, most recently from 5f61377 to 2d85668 Compare November 24, 2023 15:22
Copy link

gitguardian bot commented Nov 27, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8431139 Generic High Entropy Secret e866055 backend/src/configs/default.yaml View secret
8431140 Generic High Entropy Secret b904e44 docker/.env.example View secret
8431140 Generic High Entropy Secret e866055 backend/.env.example View secret
8431140 Generic High Entropy Secret e866055 docker/.env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bigabig bigabig merged commit 1d451cf into mwp_v1 Nov 27, 2023
4 of 5 checks passed
@floschne floschne deleted the initialize-with-migrations branch February 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use migrations to initialize new databases
2 participants