Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a leadtime argument to the chgres_cube driver. #641

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Add a leadtime argument to the chgres_cube driver. #641

merged 5 commits into from
Nov 1, 2024

Conversation

christinaholtNOAA
Copy link
Contributor

Synopsis

Fixes #640

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA self-assigned this Nov 1, 2024
WeirAE
WeirAE approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and should help to smooth out the SRW code too, LGTM

@christinaholtNOAA christinaholtNOAA merged commit bf01a96 into ufs-community:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@Byrnetp Byrnetp Byrnetp approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
None yet
Projects
Unified Workflow Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The chgres_cube driver needs a --leadtime argument.
6 participants
@christinaholtNOAA @Byrnetp @WeirAE @NaureenBharwaniNOAA @maddenp-noaa @elcarpenterNOAA