Sixth reconciliation PR from production/RRFS.v1

[grantfirl]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This PR moves two PRs from production/RRFS.v1 to the develop branch:

#2226 from @MatthewPyle-NOAA

Provides a set of changes changes needed to take advantage of FMS parallel IO changes. Changes courtesy of Dan Kokron of GDIT.

#2249 from @dustinswales

This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.

Commit Message:

* UFSWM - Provides a set of changes changes needed to take advantage of FMS parallel IO changes; adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions
  * FV3 - Provides a set of changes changes needed to take advantage of FMS parallel IO changes; adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions
    * ccpp-physics - adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions
    * atmos_cubed_sphere - Provides a set of changes changes needed to take advantage of FMS parallel IO changes

Priority:

• High: Needed for SRW App

Git Tracking

UFSWM:

• None

Sub component Pull Requests:

• FV3: Sixth reconciliation PR from production/RRFS.v1 NOAA-EMC/fv3atm#896
  • ccpp-physics: Sixth reconciliation PR from production/RRFS.v1 ccpp-physics#235
  • atmos_cubed_sphere: Sixth reconciliation PR from production/RRFS.v1 NOAA-GFDL/GFDL_atmos_cubed_sphere#365

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[grantfirl]

Note: I pushed the Hera RT log for the tests that I ran. All tests succeeded except for 2 time-outs. I did not re-run those, but they are not expected to fail if they are re-run. Perhaps they need more wallclock time added?

[jkbk2004]

@grantfirl Sorry for delay! as wcoss2 maintenance continues, we may pursue baseline change PRs first. can you sync up this pr? CDEPS update PR #2538 has no baseline change as well. It's good to combine. Just need to point to https://github.com/NickSzapiro-NOAA/CDEPS/tree/sync_escomp_2024-12-16

[grantfirl]

@grantfirl Sorry for delay! as wcoss2 maintenance continues, we may pursue baseline change PRs first. can you sync up this pr? CDEPS update PR #2538 has no baseline change as well. It's good to combine. Just need to point to https://github.com/NickSzapiro-NOAA/CDEPS/tree/sync_escomp_2024-12-16

@jkbk2004 OK, everything has been synced and #2538 has been combined into this. It should be ready to go.

[jkbk2004]

A few cases with timeout issues across machines: not major problem. But on orion/hercules, control_restart_p8_intel failed in run_test

  71: zstd: Src size is incorrect
 71:
 71: FATAL from PE    71: NetCDF: HDF error: netcdf_read_data_3d: file:INPUT/fv_core.res.tile3.nc- variable:u
 71:
  0:
  0: FATAL from PE     0: NetCDF: HDF error: netcdf_read_data_3d: file:INPUT/fv_core.res.tile1.nc- variable:u

[grantfirl]

https://github.com/NOAA-EMC/fv3atm/pull/896/files#diff-ff4a849e50baa285665db70718c46db9524ddbcce15d0c6795c8078dee38195d

A few cases with timeout issues across machines: not major problem. But on orion/hercules, control_restart_p8_intel failed in run_test

  71: zstd: Src size is incorrect
 71:
 71: FATAL from PE    71: NetCDF: HDF error: netcdf_read_data_3d: file:INPUT/fv_core.res.tile3.nc- variable:u
 71:
  0:
  0: FATAL from PE     0: NetCDF: HDF error: netcdf_read_data_3d: file:INPUT/fv_core.res.tile1.nc- variable:u

@jkbk2004 @MatthewPyle-NOAA I don't think that the CCPP changes could cause this error, but perhaps the changes from #2226 could? @MatthewPyle-NOAA Have you come across a similar error before during any of your testing for the original PR?

[grantfirl]

@jkbk2004 I've asked @MatthewPyle-NOAA and @dkokron to help debug the issue since I believe that the error is coming from the parallel FMS IO changes that they introduced.