Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add smoke and dust verification #1174

Draft
wants to merge 220 commits into
base: develop
Choose a base branch
from

Conversation

mkavulich
Copy link
Collaborator

DESCRIPTION OF CHANGES:

This PR adds verification of smoke and dust observations to the SRW verification workflow. More details to follow, including documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • derecho.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS (optional):

gsketefian added 30 commits July 9, 2024 13:57
…the tar file where the prepbufr files live changed"
…y Michelle Harrold, solution by Michael Kavulich.
…ing cycles for CCPA and MRMS but not yet for NDAS or NOHRSC.
…thout performing unnecessary repeated pulls.
…files from HPSS (and works with multiple cycles).
…les, that are expected to be created once the task is finished actually get created. This is needed because it is possible that for some forecast hours for which there is overlap between cycles, the files are being retrieved and processed by the get_obs_... task for another cycle.
…nd EnsembleStat tasks such that GenEnsProd does not depend on the completion of get_obs_... tasks (because it doesn't need observations) but only forecast output while EnsembleStat does.
…d due to changes to dependencies of GenEnsProd tasks in previous commit(s).
…sure PcpCombine operates only on those hours unique to the cycle, i.e. for those times starting from the initial time of the cycle to just before the initial time of the next cycle. For the PcpCombine_obs task for the last cycle, allow it to operate on all hours of that cycle's forecast. This ensures that the PcpCombine tasks for the various cycles do not clobber each other's output. Accordingly, change the dependencies of downstream tasks that depend on PcpCombine obs output to make sure they include all PcpCombine_obs tasks that cover the forecast period of the that downstream task's cycle.
…ossibly also get_obs_ndas by putting in sleep commands.
gsketefian and others added 29 commits November 3, 2024 03:50
…s 'ADPSFC' and 'ADPUPA' being changed to 'SFC' and 'UPA'.
…s 'ADPSFC' and 'ADPUPA' being changed to 'SFC' and 'UPA'.
…field group names 'ADPSFC' and 'ADPUPA' being changed to 'SFC' and 'UPA'.
…nistic vx. Make corresponding changes in the docs.
…so, fix problems with POINT_STAT_MESSAGE_TYPE for Airnow obs
 - Better description for METPLUS_VERBOSITY_LEVEL
 - Convert all the REMOVE_RAW_OBS_* vars to a single REMOVE_RAW_OBS_DIRS
variable. Way less complicated and you should never absolutely NEED to
specify this by ob type
 - Better descriptions for some AQ variables

Includes mods to get_obs.py for REMOVE_RAW_OBS_DIRS
… add matched-pairs to stat files for smoke variables
@mkavulich mkavulich changed the title Feature/add smoke vx [develop] Add smoke and dust verification Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants