Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Correct documentation issue and close out two issues #1169

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[develop] Correct documentation issue and close out two issues #1169

merged 2 commits into from
Jan 7, 2025

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

The documentation has been failing for the last week due to the https://www.ncep.noaa.gov website being unresponsive. This site URL has been replaced with https://www.weather.gov/ncep/.

The following two issues have also been addressed in this PR:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

  • hera.intel
  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes #1144
Fixes #979

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@MichaelLueken
[feature/doc_fix_comp_update]
f3c2e3b 
 * doc/UsersGuide/Reference/Glossary.rst - Replace unresponsive https://www.ncep.noaa.gov URL with https://www.weather.gov/ncep/
 * machine_suites/comprehensive.derecho - Add back in ufs-case-studies tests
@MichaelLueken
[feature/doc_fix_comp_update] Change default FV3GFS_FILE_FMT_ICS and …
d66fa69 
…FV3GFS_FILE_FMT_LBCS from nemsio to netcdf. Ensure all WE2E configurations include FV3GFS_FILE_FMT_ICS and FV3GFS_FILE_FMT_LBCS.
@MichaelLueken MichaelLueken added bug Something isn't working enhancement New feature or request labels Dec 17, 2024
@MichaelLueken
Copy link
Collaborator Author

The comprehensive tests were run on Hera following this update and they all passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
2020_CAD_20241217144408                                            COMPLETE              65.50
2020_CAPE_20241217144409                                           COMPLETE              66.86
2019_hurricane_barry_20241217144409                                COMPLETE              65.87
2019_halloween_storm_20241217144410                                COMPLETE              64.02
2019_hurricane_lorenzo_20241217144411                              COMPLETE              65.42
2019_memorial_day_heat_wave_20241217144412                         COMPLETE              63.14
2020_denver_radiation_inversion_20241217144412                     COMPLETE              66.83
2020_easter_storm_20241217144413                                   COMPLETE              65.35
2020_jan_cold_blast_20241217144414                                 COMPLETE              65.54
community_20241217144414                                           COMPLETE              28.67
custom_ESGgrid_20241217144415                                      COMPLETE              29.44
custom_ESGgrid_Central_Asia_3km_20241217144416                     COMPLETE              57.56
custom_ESGgrid_Great_Lakes_snow_8km_20241217144416                 COMPLETE              23.51
custom_ESGgrid_IndianOcean_6km_20241217144418                      COMPLETE              31.73
custom_ESGgrid_NewZealand_3km_20241217144419                       COMPLETE             125.80
custom_ESGgrid_Peru_12km_20241217144419                            COMPLETE              40.35
custom_ESGgrid_SF_1p1km_20241217144420                             COMPLETE             386.32
custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE_202  COMPLETE              13.59
custom_GFDLgrid_20241217144421                                     COMPLETE              12.46
deactivate_tasks_20241217144422                                    COMPLETE               1.29
get_from_AWS_ics_GEFS_lbcs_GEFS_fmt_grib2_2022040400_ensemble_2me  COMPLETE            1674.11
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200_2024121  COMPLETE              10.51
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2019061200_202412  COMPLETE              13.02
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2021032018_202412  COMPLETE              13.09
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_netcdf_2022060112_48h_20  COMPLETE             104.25
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2  COMPLETE            1735.20
get_from_HPSS_ics_GSMGFS_lbcs_GSMGFS_20241217144427                COMPLETE              10.80
get_from_HPSS_ics_HRRR_lbcs_RAP_20241217144428                     COMPLETE              21.35
get_from_HPSS_ics_RAP_lbcs_RAP_20241217144428                      COMPLETE              25.57
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS_20241217144429              COMPLETE              16.24
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_202  COMPLETE              14.82
grid_CONUS_3km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_  COMPLETE             622.92
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20241  COMPLETE             155.22
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241217144432  COMPLETE             418.74
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241217144  COMPLETE              52.40
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              72.42
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024121714  COMPLETE              58.89
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              60.04
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               8.26
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              27.58
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              26.94
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024121714  COMPLETE              12.62
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241217144  COMPLETE              56.25
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              26.62
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP_20241217144441  COMPLETE              14.93
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2_20241  COMPLETE              11.22
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121714444  COMPLETE              51.23
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_RRFS_v1beta_202412171  COMPLETE              24.55
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_202412  COMPLETE             532.51
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             727.88
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_20241217  COMPLETE             708.35
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241217144  COMPLETE             825.41
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_2024  COMPLETE             837.33
grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              59.77
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR_20241217  COMPLETE              58.44
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              59.11
grid_RRFS_CONUScompact_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              15.73
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              49.29
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              14.69
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_v1beta_  COMPLETE              18.33
grid_RRFS_CONUScompact_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_2  COMPLETE             625.81
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR_202412171  COMPLETE             733.72
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             768.15
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241217144457  COMPLETE             158.06
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0_202412  COMPLETE              50.35
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121714445  COMPLETE              34.55
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241217144  COMPLETE              26.62
grid_SUBCONUS_Ind_3km_ics_NAM_lbcs_NAM_suite_GFS_v16_202412171445  COMPLETE              38.35
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              18.43
long_fcst_20241217144503                                           COMPLETE             124.95
MET_ensemble_verification_only_vx_20241217144504                   COMPLETE               1.13
MET_ensemble_verification_only_vx_time_lag_20241217144507          COMPLETE               4.27
MET_ensemble_verification_winter_wx_20241217144510                 COMPLETE             168.80
MET_verification_only_vx_20241217144512                            COMPLETE               0.28
pregen_grid_orog_sfc_climo_20241217144514                          COMPLETE              10.71
specify_EXTRN_MDL_SYSBASEDIR_ICS_LBCS_20241217144516               COMPLETE              10.62
specify_template_filenames_20241217144517                          COMPLETE              11.47
vx-det_long-fcst_custom-vx-config_aiml-fourcastnet_20241217144517  COMPLETE               0.68
vx-det_long-fcst_custom-vx-config_aiml-graphcast_20241217144520    COMPLETE               0.69
vx-det_long-fcst_custom-vx-config_aiml-panguweather_2024121714452  COMPLETE               0.69
vx-det_long-fcst_custom-vx-config_gfs_20241217144524               COMPLETE               0.70
vx-det_long-fcst_winter-wx_SRW-staged_20241217144526               COMPLETE               1.14
vx-det_multicyc_fcst-overlap_ncep-hrrr_20241217144528              COMPLETE               3.61
vx-det_multicyc_first-obs-00z_ncep-hrrr_20241217144531             COMPLETE               0.80
vx-det_multicyc_last-obs-00z_ncep-hrrr_20241217144533              COMPLETE               0.91
vx-det_multicyc_long-fcst-no-overlap_nssl-mpas_20241217144535      COMPLETE              13.27
vx-det_multicyc_long-fcst-overlap_nssl-mpas_20241217144538         COMPLETE              12.21
vx-det_multicyc_no-00z-obs_nssl-mpas_20241217144540                COMPLETE               0.79
vx-det_multicyc_no-fcst-overlap_ncep-hrrr_20241217144542           COMPLETE               1.94
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE           13409.58

@MichaelLueken
Copy link
Collaborator Author

The ufs-case-studies tests were run on Derecho and all successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
2019_hurricane_barry_20241216121123                                COMPLETE              75.74
2020_CAD_20241216121124                                            COMPLETE              77.14
2019_memorial_day_heat_wave_20241216121125                         COMPLETE              74.76
2020_denver_radiation_inversion_20241216121126                     COMPLETE              75.62
2020_jan_cold_blast_20241216121127                                 COMPLETE              77.73
2019_halloween_storm_20241216121128                                COMPLETE              78.96
2019_hurricane_lorenzo_20241216121129                              COMPLETE              73.96
2020_CAPE_20241216121130                                           COMPLETE              74.79
2020_easter_storm_20241216121131                                   COMPLETE              72.96
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             681.66

@MichaelLueken
Copy link
Collaborator Author

Finally, the AQM and UFS-Fire WE2E tests were run on Hera and successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20241217181625                   COMPLETE            2860.58
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2860.58

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
UFS_FIRE_multifire_one-way-coupled_20241217173221                  COMPLETE              13.20
UFS_FIRE_one-way-coupled_20241217173223                            COMPLETE              13.20
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              26.40

gspetro-NOAA
gspetro-NOAA approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the UFS case studies work on Derecho, and the fundamental tests all pass there, too.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Jan 6, 2025
@MichaelLueken
Copy link
Collaborator Author

There had been an issue with the vx-det_long-fcst_winter-wx_SRW-staged WE2E test on Hera GNU. Using rocotorewind and rocotoboot on the failed task allowed the test to successfully run:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
custom_ESGgrid_Central_Asia_3km_20250106161742                     COMPLETE             333.29
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2019061200_202501  COMPLETE              15.22
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS_20250106161744              COMPLETE              23.61
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025010616  COMPLETE             452.34
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              34.83
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250106161  COMPLETE              34.86
long_fcst_20250106161747                                           COMPLETE             384.62
MET_verification_only_vx_20250106161747                            COMPLETE               0.31
MET_ensemble_verification_only_vx_time_lag_20250106161749          COMPLETE              13.02
2019_halloween_storm_20250106161752                                COMPLETE             618.27
2020_jan_cold_blast_20250106161753                                 COMPLETE             759.79
vx-det_long-fcst_custom-vx-config_aiml-fourcastnet_20250106161753  COMPLETE               0.77
vx-det_long-fcst_custom-vx-config_aiml-panguweather_2025010616175  COMPLETE               0.77
vx-det_long-fcst_custom-vx-config_gfs_20250106161757               COMPLETE               0.78
vx-det_long-fcst_winter-wx_SRW-staged_20250106161759               COMPLETE               1.42
vx-det_multicyc_fcst-overlap_ncep-hrrr_20250106161801              COMPLETE               7.30
vx-det_multicyc_last-obs-00z_ncep-hrrr_20250106161803              COMPLETE               1.37
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2682.57

The rest of the automated tests successfully passed. Moving forward with merging this PR now.

@MichaelLueken MichaelLueken merged commit f04f085 into ufs-community:develop Jan 7, 2025
6 checks passed
@MichaelLueken MichaelLueken mentioned this pull request Jan 7, 2025
Open
@MichaelLueken MichaelLueken deleted the feature/doc_fix_comp_update branch January 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@natalie-perlin natalie-perlin natalie-perlin approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich is a code owner

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA is a code owner

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA RatkoVasic-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa christopherwharrop-noaa is a code owner

@danielabdi-noaa danielabdi-noaa Awaiting requested review from danielabdi-noaa danielabdi-noaa is a code owner

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts mark-a-potts is a code owner

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield willmayfield is a code owner

@dmwright526 dmwright526 Awaiting requested review from dmwright526 dmwright526 is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA is a code owner

@rickgrubin-noaa rickgrubin-noaa Awaiting requested review from rickgrubin-noaa rickgrubin-noaa is a code owner

@BruceKropp-Raytheon BruceKropp-Raytheon Awaiting requested review from BruceKropp-Raytheon BruceKropp-Raytheon is a code owner

@BenKoziol-NOAA BenKoziol-NOAA Awaiting requested review from BenKoziol-NOAA BenKoziol-NOAA is a code owner

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Milestone
No milestone
3 participants
@MichaelLueken @natalie-perlin @gspetro-NOAA