In GFS_phys_time_vary.fv3: make is_initialized a host model variable to support multiple instances of CCPP physics in a model run #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: support multiple instances by making is_initialized a host-model variable
This was referenced Dec 19, 2024
climbfuji
requested review from
grantfirl,
rhaesung,
Qingfu-Liu and
dustinswales
as code owners
dustinswales
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is similar to what @dustinswales did for
mp_thompson. In order to support multiple instances of CCPP physics within one model execution (for example for ensemble DA), we need to makeis_initializeda host model variable.While working on that scheme, I removed the unused=empty
timestep_finalizeroutine.This PR is the last change that is needed to replace NCAR#1000 (all other changes were made by @dustinswales in a series of PRs over the last year or two).
Associated fv3atm and ufs-weather-model PRs:
NOAA-EMC/fv3atm#902
ufs-community/ufs-weather-model#2544