Update orography code for low-res grids #1012
Draft
+1,886
−254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'grid' files. Fixes ufs-community#1000.
one of the polygon's corner points. Fixes ufs-community#1000.
Add check to ensure grid dimensions of the orog file are correct. Fixes ufs-community#1000.
for several tests. Fixes ufs-community#1000.
of netcdf. Fixes ufs-community#1000.
of netcdf. Fixes ufs-community#1000.
that routine. Fixes ufs-community#1000.
data from the file. This will make unit testing easier. Also, update the routine to use the f90 netcdf routines. Fixes ufs-community#1000.
9-degrees for the coarsest atmospheric resolutions. Fixes ufs-community#1000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Low-resolution grids are defined as C24/C18/C12.
1 - Updates to the orography code:
read_global_orogandread_global_mask- A check was added to ensure the i/j-dimensions of the global data match the dimensions passed in as arguments.qc_orog_by_rampwas updated to read the j-dimension of the RAMP data from the file itself, instead of being declared in the routine. This made writing a unit test easier.makemt2- variable "maxsum" is now calculated dynamically instead of being hardwired. The hardwired value was not large enough for grids coarser than C48.make_mask- variable "maxsum" is not used and was removed.remove_isolated_pts- This routine was originally written for the global gaussian grid. Some of the logic did not work for FV3 tiles. To fix, the check along the "east/west" tile edges was removed. Also removed was logic that was (I believe) used for reduced gaussian grids (where the number of 'i' points decreased toward the poles).2 - New unit tests for the following routines/functions:
TESTS CONDUCTED:
grid_genconsistency tests locally on all Tier 1 machines. Done on Hercules, Jet, Cactus and Orion using 64d26a4. All tests passed as expected.orog.fdcode had no warnings.Describe any additional tests performed.
./driver_scripts/driver.hercules.shDEPENDENCIES:
None.
DOCUMENTATION:
Doxygen successfully created. See above.
ISSUE
Fixes #1000.
RELATED ISSUES
ufs-community/ufs-weather-model#2508