-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fixed allowFullscreen not working correctly. Added autoplay and progress bar color parameters * Added cc language preference, cc load policy, disable keyboard controls, end time and interface language parameters * Added enable IFrame API, iv load policy, loop, modest branding, origin and playlist parameters * Updated the youtube extension documentation Co-authored-by: luis.feliu <[email protected]>
- Loading branch information
1 parent
e269b36
commit c1cf33c
Showing
3 changed files
with
281 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1cf33c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuchoCateura!
This change happened a while back, but do you by any chance remember the reason for rendering all of these attributes to the DOM itself?
According to YouTube’s own docs, most of the interface props don’t need to be added anywhere else than in the embed url itself. Is this done to somehow simplify state management over parsing and stringifying URL queries all the time, or for a different reason?
The reason I’m asking as that I want to get rid of most of the DOM attributes, since styled-components is complaining about a lot of them. I can bypass it, of course – but if there’s no actual need to have them as rendered attributes, I’d rather they be gone, and I might then make a PR to for that.
Grateful for any response and input!