Skip to content

Commit

Permalink
add note why we had to use our own cordsAtPos implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
Chrissi2812 committed Mar 7, 2019
1 parent f490ca1 commit 8ddc0c0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/tiptap/src/Plugins/MenuBubble.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ class Menu {
const { from, to } = state.selection

// These are in screen coordinates
// We can't use EditorView.cordsAtPos here because it can't handle linebreaks correctly
// See: https://github.com/ProseMirror/prosemirror-view/pull/47
const start = coordsAtPos(view, from)
const end = coordsAtPos(view, to, true)

Expand Down

0 comments on commit 8ddc0c0

Please sign in to comment.