Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/list #3164

Merged
merged 8 commits into from
May 1, 2024
Merged

Fix/list #3164

merged 8 commits into from
May 1, 2024

Conversation

felixfeng33
Copy link
Collaborator

Description

See changesets.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 418d385

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@udecode/slate Patch
@udecode/plate-indent-list Patch
@udecode/plate-common Patch
@udecode/plate-core Patch
@udecode/plate-utils Patch
@udecode/slate-react Patch
@udecode/slate-utils Patch
@udecode/plate Patch
@udecode/plate-serializer-docx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 10:01am

zbeyens
zbeyens reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We also need to update changeset.mdx

apps/www/src/registry/default/plate-ui/indent-todo-marker-component.tsx Outdated
Comment on lines 21 to 28
onMouseDown={(e: any) => {
/**
* click the checkbox should not losing the focus.
*/
e.preventDefault();
const checked = e.target.getAttribute('aria-checked') !== 'true';
onChange(checked);
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be encapsulated in a prop hook from @udecode/plate-indent-list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we keep the onCheckedChange prop and just do preventDefault inside the onMouseDown handler? onMouseDown doesn't work with assistive technology.

@felixfeng33
Copy link
Collaborator Author

felixfeng33 commented Apr 30, 2024 •
edited
Loading

Great! We also need to update changeset.mdx

what is the changeset.mdx?

@zbeyens
Copy link
Member

zbeyens commented Apr 30, 2024 •
edited
Loading

@felixfeng33 typo, it's changelog.mdx, that needs updates for each registry change

@felixfeng33
Copy link
Collaborator Author

felixfeng33 commented Apr 30, 2024 •
edited
Loading

changelog

@felixfeng33 typo, it's changelog.mdx, that needs updates for each registry change

Doesn't this update automatically?,If I have added the changeset.

@felixfeng33 felixfeng33 requested a review from zbeyens May 1, 2024 09:26
@zbeyens zbeyens merged commit 296cf69 into main May 1, 2024
3 of 4 checks passed
@zbeyens zbeyens deleted the fix/list branch May 1, 2024 09:45
@github-actions github-actions bot mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12joan 12joan 12joan left review comments

@zbeyens zbeyens Awaiting requested review from zbeyens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfeng33 @zbeyens @12joan