Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solid-jotai-x #16

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add solid-jotai-x #16

wants to merge 3 commits into from

Conversation

rtritto
Copy link

@rtritto rtritto commented Aug 17, 2024 •
edited
Loading

TODO

  • update compilerOptions in tsconfig.json

    {
  "compilerOptions": {
    "jsx": "preserve",
    "jsxImportSource": "solid-js"
  }
}

  • replace @testing-library/react in spec (test) files

  • add ESLint

@rtritto rtritto changed the title Solid jotai x init Add solid-jotai-x Aug 17, 2024
zbeyens
zbeyens reviewed Aug 17, 2024
View reviewed changes
Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left a few comments

packages/solid-jotai-x/CHANGELOG.md
@@ -0,0 +1,54 @@
# jotai-x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File can be removed

packages/solid-jotai-x/README.md
@@ -0,0 +1,253 @@
# JotaiX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be adapted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeyens zbeyens zbeyens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtritto @zbeyens