Resolve type constructors in qualifiers via LHNames #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/qualifiers-renaming2
branch
from
856ae98 to
474b2c8
Compare
|
@clayrat, maybe you would like to review this one. |
clayrat
reviewed
Jan 14, 2025
liquidhaskell-boot/src/Language/Haskell/Liquid/LHNameResolution.hs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step for #2169
This PR reports unresolved type constructors one error at a time for qualifiers, and in a separate phase than the rest of name resolution.
I explored integrating name resolution of qualifiers in a single phase with the rest, but this turned out to be not trivial because the qualifier representation is defined in
liquid-fixpoint.