Change contract bytecode location to bytecode.hex #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degrigis
reviewed
Dec 18, 2023
The included download script creates a `contract.hex` which contains the bytecode. This is nice, but Gigahorse already places the bytecode in `bytecode.hex`. Let's just use the one placed there by Gigahorse. Otherwise, it's annoying if that specific downloader script isn't used.
robmcl4
force-pushed
the
change_hex_loc
branch
from
5bdaf27
to
c93d205
Compare
|
rebased onto main and broke out contract bytecode loading into separate function |
|
Addressed in commit 75cee2c (always rename bytecode.hex to contract.hex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included download script creates a
contract.hexwhich contains the bytecode. This is nice, but Gigahorse already places the bytecode inbytecode.hex. Let's just use the one placed there by Gigahorse. Otherwise, it's annoying if that specific downloader script isn't used.