Issue 562: Revise pattern:patternExpression to be object property, and test for error form #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is spelled as a "Negative" constraint to avoid attempting to hard-code a list of the recognized OWL "built-in" datatypes alongside custom RDFS datatypes (such as UCO's vocabulary namespace members). The anonymous node shape design pattern is documented in PR 564, commit 77cd47d. This patch is known to fail CI at the moment because it catches the error described in 562, but does not resolve that situation. This patch is provided now to prevent this implementation error pattern from arising in the future. References: * #562 * 77cd47d Signed-off-by: Alex Nelson <[email protected]>
This patch is implemented based on the early draft-state of Issue 550, to correct the issue reported in Issue 562. No effects were observed on Make-managed files. References: * #550 * #562 Signed-off-by: Alex Nelson <[email protected]>
15 tasks
15 tasks
Commit ba77dea used a design pattern that I now believe is not applicable. This patch revises the new shape to the corrected from now in PR 564. No effects were observed on Make-managed files. References: * #562 * 6669aab Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. References: * #562 Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. References: * #562 Acked-by: Paul Brandt <[email protected]> Signed-off-by: Alex Nelson <[email protected]>
|
This PR is ready for review and merge. |
plbt5
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
the comment of the property pattern:patternExpression, i.e.,
rdfs:comment "An explicit logical pattern expression."@en ,
is formulated as if the element that is addressed is a Class as opposed to a property. I consider this a minor issue not relevant for this review, hence my approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves all requirements of Issue #562 .
Coordination
develop-2.0.0unstable-2.0.0branch (7dc3423)unstable-2.0.0branch tracking UCO'sunstable-2.0.0as submodule (4aff9c9)