-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap repository for v1.0.0 #1
Conversation
Wiz Scan Summary
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but otherwise looks good!
Description
Continuing on from the discussion in https://github.com/uclahs-cds/group-infrastructure/discussions/62#discussioncomment-9135287, this repository is the new home of the build-and-deploy-docs action from https://github.com/uclahs-cds/tool-Nextflow-action.
Nearly all of the code in the PR is identical to the old action, with a few tweaks that I'll detail below.
Substantial Changes
I wanted to include the
actions/checkout
step inside this action, but as the original was a Docker container action there was not a simple mechanism to add that in.To work around that, I modified this example and buried the original action into an
internal-action
folder. Then, I added a new wrapper composite action with the same arguments that ranactions/checkout
before calling theinternal-action
.Similar to the discussion in uclahs-cds/tool-static-analysis#1 (comment) (composite actions can't access the
github
context), that does require copying theinternal-action
folder into the.git/
folder of the calling repository to work.tool-generate-docs/action.yml
Lines 14 to 25 in b8f9612
The only file that needed to be changed to make this work was the (not actually involved with the action) helper script
backfill.py
:The rest of the copied files are identical:
Dockerfile
action.py
create_mkdocs_config.py
requirements.txt
action.yml
Checklist
This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
Disclosing PHI is a major problem1 - Even a small leak can be costly2.
This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other output files.To automatically exclude such files using a .gitignore file, see here for example.
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
main
branch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.Footnotes
UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records ↩
The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. ↩
Genetic information is considered PHI.
Forensic assays can identify patients with as few as 21 SNPs ↩
RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity. ↩