Skip to content

Commit

Permalink
Merge pull request #270 from uclahs-cds/sfitz-strelka-retry
Browse files Browse the repository at this point in the history
Sfitz strelka retry
  • Loading branch information
sorelfitzgibbon authored Jan 29, 2024
2 parents 1360225 + 6560630 commit 3a7960d
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [8.0.0-rc.1] - 2023-12-13

### Changed
- `Strelka2` retry triggered by error code `1`
- Use external `indexFile` function
- Update submodules
- Sample names sanitized for all output
Expand Down
2 changes: 1 addition & 1 deletion config/F16.config
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ process {
retry_strategy {
memory {
strategy = 'add'
operand = 4.GB
operand = 12.GB
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion config/F32.config
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ process {
retry_strategy {
memory {
strategy = 'add'
operand = 5.GB
operand = 12.GB
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion config/F72.config
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ process {
retry_strategy {
memory {
strategy = 'add'
operand = 5.GB
operand = 12.GB
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion config/base.config
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
process {
cpus = { methods.check_limits( 1 * task.attempt, 'cpus' ) }

errorStrategy = { task.exitStatus in [143, 137, 104, 134, 139] ? 'retry' : 'finish' }
commonRetryCodes = [104, 134, 137, 139, 143, 247] // Common out-of-memory error codes
withName: 'call_sSNV_Strelka2' {
ext.retry_codes = [1] // call_sSNV_Strelka2 doesn't differentiate memory errors
}

errorStrategy = { task.exitStatus in (((task?.ext?.retry_codes) ? task.ext.retry_codes : []) + process.commonRetryCodes) ? 'retry' : 'terminate' }
maxRetries = 1

withLabel:process_low {
Expand Down
2 changes: 1 addition & 1 deletion test/config/a_mini-strelka2.config
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ params {
dataset_id = 'TWGSAMIN'
// set params.exome to TRUE will add the '--exome' option when running manta and strelka2
// set params.exome to TRUE will add the '-E' option when running MuSE
exome = true
exome = false
save_intermediate_files = true

// module options
Expand Down

0 comments on commit 3a7960d

Please sign in to comment.