Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextflow.config to release management process #231

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

nwiltsie
Copy link
Member

The PR I made previously to manage the release process neglected a very important part - updating the embedded version number!

All this PR does is register the nextflow.config file with the action to ensure that it is updated when new releases are created.

@nwiltsie
Copy link
Member Author

This makes the workflow match up with recalibrate BAM's version, which I did by hand:

$ diff -u ~/src/pipeline-recalibrate-BAM/.github/workflows/prepare-release.yaml .github/workflows/prepare-release.yaml
--- /Users/nwiltsie/src/pipeline-recalibrate-BAM/.github/workflows/prepare-release.yaml	2024-10-16 09:38:01
+++ .github/workflows/prepare-release.yaml	2024-10-31 12:26:16
@@ -30,5 +30,4 @@
       bump_type: ${{ inputs.bump_type }}
       prerelease: ${{ inputs.prerelease }}
       version_files: nextflow.config
-    # Secrets are only required until tool-create-release is made public
     secrets: inherit

That workflow correctly updates the Nextflow config file: uclahs-cds/pipeline-recalibrate-BAM#86

@nwiltsie nwiltsie requested a review from a team October 31, 2024 19:28
Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nwiltsie nwiltsie merged commit d7fc101 into main Oct 31, 2024
5 checks passed
@nwiltsie nwiltsie deleted the nwiltsie_fix_pipeline_release_management branch October 31, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants