Refactor ApplicationBuilder into Ligare.programming, removing it from Ligare.web
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is partly a copy of the application builder in Ligare.web, but more generic. This is a precursor to further refactoring and changing Ligare.web to use the Ligare.programming builder.
This is a breaking change to remove the previously deprecated `create_app` and `App[T].create_app` functions. Use `ApplicationBuilder`.
…rogramming`. This change is necessary to allow non-web applications like CLI apps.
type generic var binding.
aholmes
requested review from
nwiltsie,
dan-knight,
yashpatel6,
j2salmingo and
kiarod
aholmes
added
enhancement
dan-knight
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ApplicationBuilderclass currently exists inLigare.web. This works fine for building web applications, but Ligare is meant to be neutral regarding the type of application a developer wants to build, especially CLI apps. Currently, usingApplicationBuildermeans pulling inLigare.webas a dependency. In order to avoid that, this change refactorsApplicationBuilderto instead be defined inLigare.programming, removing it fromLigare.web. From there,Ligare.webextends the refactoredApplicationBuilderinto its own builder for web applications.This refactor also required adjustments to the Config system in
Ligare.programmingto allow more neutral handling of application configuration needs.The
CreateFlaskApptest class has been updated to support the refactors.Some error messages have been updated to be less obtuse.
Important: the previously deprecated
create_appandApp[T].create_appmethods have been removed. It was not possible to update these methods to support the refactor without muddying other code unnecessarily, so this PR removes them.