Make feature flags easier to use and fix database errors #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifying the type of feature flag router as a separate module.
aholmes
force-pushed
the
aholmes-feature-flag-changes
branch
from
023d8c8 to
ffd1829
Compare
The `cast` for the FeatureFlagRouters is necessary for Injector to correctly resolve and inject instances of the type. The actual type is `Self | FeatureFlagRouter[...]`, but the usages of the injected type do not rely on `Self`, which messes up how Injector resolves dependencies.
Ligare needs a way to understand the base SQLAlchemy classes involved in querying a database. This is for a few reasons: - schema translation for systems that don't support schemas - supporting schemas in general - not overwritting `ScopedSession` registration when multiple `ScopedSession` instances are registered with Injector
This protects the class against modifications from instantiations during an application runtime. It also resolves static type errors from private member usages.
aholmes
changed the title
dan-knight
approved these changes
Oct 31, 2024
Yes, I will add some docstrings and some examples to the "cookbook" idea. |
Cookbook is perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
feature_flagdecoratorLigare.webapplication contexts