Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically replace pickmybruin #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinkassimo
Copy link
Member

@kevinkassimo kevinkassimo commented May 14, 2018

Using command:

LC_ALL=C find . -type d -name ".git" -prune -o -type f -exec sed -i ''
-e 's/pickmybruin/bquest/g' {} \;

Notice also done manual replacement of src/pickmybruin to src/bquest

Description

Pls do

  • Tested and working
  • Unit tests

Test plan

Make sure nothing is broken. May need more testing before accepting the pull request.
Seems working currently on dev server though.

Also, this change requires complete rename of the image also.

I have also noticed the .gitignore problem, this may mean for those ignored files, renaming is also necessary

Using command:

LC_ALL=C find . -type d -name ".git" -prune -o -type f -exec sed -i ''
-e 's/[Pp]ick[Mm]y[Bb]ruin/BQuest/g' {} \;

Notice also done manual replacement of `src/pickmybruin` to `src/bquest`
@marktai
Copy link
Collaborator

marktai commented May 15, 2018

Can you please run the unit tests and check that box off?

@marktai
Copy link
Collaborator

marktai commented May 15, 2018

also you probably want to keep both pickmybruin and bquest in the gitignore

Copy link
Collaborator

@marktai marktai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@kevinkassimo
Copy link
Member Author

@marktai Temporarily putting this on hold, until front end issues are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants