Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cyanea #141

Merged
merged 3 commits into from
Jan 7, 2024
Merged

feat/cyanea #141

merged 3 commits into from
Jan 7, 2024

Conversation

Arc-blroth
Copy link
Member

@Arc-blroth Arc-blroth commented Jan 7, 2024

  • upgrade yarn -> v4.0.2
  • Migrate to our new shiny Cyanea events!

One of the last steps in my winter-long project to automate basically all of marketing:tm:!

This PR replaces and deduplicates the original event/archive system with a single source of truth in data/events.json.

It also fixes a couple of bugs and limitations with the original event system:

  • Events now get automatically moved to the archive based on their timestamp (sorry Audrey)
  • Events now have both a start and end time, and can theoretically last for multiple days
  • Events can now be tagged with multiple Cyber "series"/tracks/things
  • the components on the Events and Archive pages are now actual React components, with proper keys
  • the alt text for event banners is no longer "Placeholder Image" 🧌
  • #bringbackspecialtopics

There's actually a couple of typos in the events.json currently supplied ("Polygots") for both recent and historical events.
I plan to fix those typos as a demostration in the first real Cyanea sync - coming soon!

@Arc-blroth Arc-blroth requested a review from bliutech January 7, 2024 10:32
Copy link
Member

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Great work. LGTM.

@bliutech bliutech merged commit 9ed4712 into main Jan 7, 2024
@bliutech bliutech deleted the feat/cyanea branch January 7, 2024 17:28
burturt pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants