MXHammer experimental version #859
Conversation
…into ams_experimental Documentation
…ommands, and removed hardcoded options
…into ams_experimental merged
| @@ -3,9 +3,9 @@ vlsi_dir=$(abspath .) | |||
|
|
|||
|
|
|||
| # minimal flow configuration variables | |||
| design ?= pass | |||
| design ?= level_shifter | |||
There was a problem hiding this comment.
Is this the design you tested on? If so, either add the sources to e2e/ or change this back.
Also, below in this file, please keep the clean target.
There was a problem hiding this comment.
General comment on this file: you can put most of this info (starting at section 2, since the setup is common) in hammer/sim/xcelium/README.md and then link that file to the main Hammer documentation with a symbolic link like this: https://github.com/ucb-bar/hammer/blob/master/doc/CAD-Tools/Joules.md.
When doing so, remove references to your experimental branch (this is getting merged), the term "MXHammer" (doesn't mean anything), and references to your workspace path. If possible, delineate regular Xcelium (digital sim) setup vs. MX setup when you update this documentation.
There was a problem hiding this comment.
Since this is in e2e, it would be OK to put BWRC-specific paths into this file (then link to it from the README document).
| @@ -377,6 +390,80 @@ def generate_sim_tcl(self) -> bool: | |||
| f.close() | |||
| return True | |||
|
|
|||
| """def generate_amscf(self) -> bool: | |||
| """ | ||
|
|
||
| # Get analog models, schematics from directories specified in extralibs | ||
| extralib = self.get_setting("vlsi.technologies.extra_libraries") |
There was a problem hiding this comment.
This key doesn't exist... what are you trying to do/specify here? Do you need fields added to the normal vlsi.technology.extra_libraries key?
hammer/hammer/tech/__init__.py
Line 249 in 5277152
| f = open(runpath, "w+") | ||
|
|
||
| # Write Shebang + xrun clean | ||
| f.write("#!/bin/csh -f\n#\nxrun -clean \\\n") |
There was a problem hiding this comment.
Does this only work in csh? Generally we want users to use bash family terminals.
| @@ -1,11 +1,18 @@ | |||
| sim.xcelium: | |||
| # Tool version (e.g., "XCELIUM2103") | |||
| # Tool version (e.g., "XCELIUM2103") | |||
| version: "XCELIUM2103" | ||
|
|
||
| # Spectre version (e.g., "SPECTRE211") |
There was a problem hiding this comment.
Would note that this is only required for AMS.
Added AMS simulation support through the Xcelium plugin, with hard-coded additions to arguments and constraints as of now.
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?