Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default metric reporting. Reports QoR and power metrics for predefined synthesis steps. #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added default metric reporting. Reports QoR and power metrics for predefined synthesis steps. #832

wants to merge 1 commit into from

Conversation

cadeberkeley
Copy link
Contributor

Reports metrics for elaborate, syn_generic, syn_map, and syn_opt steps.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@cadeberkeley cadeberkeley added the Cadence Specific to a Cadence tool label Nov 30, 2023
jerryz123
jerryz123 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does enabling the metrics increase run time significantly?

@cadeberkeley
Copy link
Contributor Author

Does enabling the metrics increase run time significantly?

I believe enabling power metrics does, but not QoR metrics.

harrisonliew
harrisonliew requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'd like to see how we can properly use the Stylus metrics database/dashboard across multiple runs. E.g. provide a key where the dashboard lives, and the output file should depend on the run's config/start time or similar.

hammer/synthesis/genus/__init__.py
@@ -261,6 +261,12 @@ def init_environment(self) -> bool:
# TODO: is there a way to track instance paths through the synthesis process?
verbose_append("set_db root: .auto_ungroup none")

# Enable metric tracking
verbose_append(f"set_db statistics_log_data {self.get_setting('synthesis.genus.track_qor_metrics')}")
verbose_append(f"set_db statistics_log_data {self.get_setting('synthesis.genus.track_qor_metrics')}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 left review comments

@harrisonliew harrisonliew harrisonliew requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Cadence Specific to a Cadence tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadeberkeley @harrisonliew @jerryz123