Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass p_syn_in to hierarchical make rules. #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerryz123
Copy link
Contributor

Previously, hierarchical steps did not see a dependence on inputs.yml, sram-generator-output.json, and your INPUT_CONFS in the hierarchical flow.

A bug could occur if the hierarchical module contained its own SRAM macro that no leaf module included. Without appending to p_syn_in, sram-generator-output.json would not be included, and the tools would not be able to resolve the path to this macro.

@colinschmidt
Copy link
Contributor

It is usually very annoying to have the later steps depend on INPUT_CONFS.
From my reading of the change you are just adding them as inputs without adding them as dependencies, which avoids this issue.
However I feel like you might want to only include the sram-generator-output.json instead of all inputs.

@jerryz123
Copy link
Contributor Author

I thought the workaround for that is to just use redo steps.

Not sure how I can parse out just the sram-generator-output.json without adding a weird special case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants