Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics traits #331

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add metrics traits #331

wants to merge 12 commits into from

Conversation

jwright6323
Copy link
Contributor

This is a draft of the metrics mix-in traits.

@hammer-robot
Copy link

Step Static type checker failed with details below:

Running mypy --package hammer_vlsi
Running mypy --package hammer_utils
Running mypy ../hammer-shell/get-config
Running mypy ../hammer-vlsi/cli_driver_test.py ../hammer-vlsi/constraints_test.py ../hammer-vlsi/lef_utils_test.py ../hammer-vlsi/tech_test.py ../hammer-vlsi/test.py ../hammer-vlsi/units_test.py ../hammer-vlsi/utils_test.py ../hammer-vlsi/verilog_utils_test.py
Running mypy ../hammer_config_test/test.py
Running mypy ../hammer-vlsi/synthesis/mocksynth/__init__.py
Running mypy ../hammer-vlsi/synthesis/vivado/__init__.py
Running mypy ../hammer-vlsi/synthesis/nop.py
Running mypy ../hammer-vlsi/par/nop.py
Running mypy ../hammer-vlsi/par/vivado/__init__.py
Running mypy ../hammer-vlsi/drc/mockdrc.py ../hammer-vlsi/drc/nop.py
Running mypy ../hammer-vlsi/lvs/mocklvs.py ../hammer-vlsi/lvs/nop.py
/buildbot/run_unittests/build/src/hammer-vlsi/hammer_vlsi/hammer_metrics.py:72: error: invalid syntax

@jwright6323 jwright6323 added enhancement high priority No workaround exists, many people blocked, chip-breaking issues metrics labels Mar 6, 2019
@jwright6323
Copy link
Contributor Author

@colinschmidt colinschmidt mentioned this pull request Mar 8, 2019
@colinschmidt
Copy link
Contributor

I think it might be better to break the fix for #280 out from a new metrics API. Just from a CR perspective I can imagine it getting confusing.

@edwardcwang
Copy link
Member

I agree with @colinschmidt here - in general for CI/CR it's nicer to have lots of small PRs than big PRs. (Sometimes it can't be helped though)

@hammer-robot

This comment has been minimized.

1 similar comment
@hammer-robot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement high priority No workaround exists, many people blocked, chip-breaking issues metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants