Add FAST CI versions of tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to add this to make the CI tests run faster? |
|
Yeah, these are used for the gemmini automatic tests |
|
But if they're running automatically anyway, then what's wrong with them taking a few hours? |
|
They time-out on the CI machines. |
hngenc
reviewed
Dec 2, 2020
bareMetalC/tiled_matmul_cpu.c
Outdated
| @@ -91,6 +91,10 @@ int main() { | |||
| } | |||
| #endif | |||
|
|
|||
| #ifdef FAST | |||
| exit(0); | |||
There was a problem hiding this comment.
Can we just not run these tests, instead of adding an early exit here?
|
Looks good to me overall. Just not sure if we need the "ifdef FAST exit(0)" lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tests to run much faster when the
-DFASTflag is passed to gcc. The FAST flag generally reduces the size of the inputs, replaces calls torand()with constants, and avoids calling the slow CPU versions of various functions.Additionally, make rules for running the tests are added.