Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Chiseltest JNI Backend #631

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

oliveryu11
Copy link

@oliveryu11 oliveryu11 commented May 4, 2023

TODOs:

  • Add a switch to go between JNI and JNA, via some annotation
  • test on other computers and validate via CI
  • Remove duplication between JNIUtils and JNAUtils
  • Do a final performance benchmark with the GCD test
  • clean up code/modified files

@CLAassistant
Copy link

CLAassistant commented May 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ vighneshiyer
❌ Oliver Yu


Oliver Yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -84,3 +84,5 @@ libraryDependencies ++= Seq(
)
}
}

fork := true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this PR, please make sure that it works without this change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is important, because otherwise it will make chiseltest harder to use.

}

val tmpDir = os.Path(System.getProperty("java.io.tmpdir"))
val jniSoDir = tmpDir / "chiseltest_jni_bridge"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you would compile everything in the local test directory instead of a temporary directory. That will make it easier for debugging.

@ekiwi
Copy link
Collaborator

ekiwi commented May 5, 2023

This looks very promising. I left some initial comments. Please ping me when this is ready for a more thorough review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants