-
Notifications
You must be signed in to change notification settings - Fork 74
Chiseltest JNI Backend #631
base: main
Are you sure you want to change the base?
Conversation
Oliver Yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -84,3 +84,5 @@ libraryDependencies ++= Seq( | |||
) | |||
} | |||
} | |||
|
|||
fork := true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge this PR, please make sure that it works without this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is important, because otherwise it will make chiseltest
harder to use.
} | ||
|
||
val tmpDir = os.Path(System.getProperty("java.io.tmpdir")) | ||
val jniSoDir = tmpDir / "chiseltest_jni_bridge" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally you would compile everything in the local test directory instead of a temporary directory. That will make it easier for debugging.
This looks very promising. I left some initial comments. Please ping me when this is ready for a more thorough review. |
TODOs: