Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firesim build.sbt from our SBT dependencies #1897

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jerryz123
Copy link
Contributor

We don't depend on firesim's build.sbt anymore

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

We don't depend on firesim's build.sbt anymore
@jerryz123 jerryz123 requested a review from joonho3020 June 7, 2024 00:41
@jerryz123 jerryz123 merged commit a6c0d1a into main Jun 7, 2024
53 of 54 checks passed
@jerryz123 jerryz123 deleted the jerryz123-patch-1 branch June 7, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants