Verification features #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New issue created for the CDL export bug: link |
ayan-biswas
approved these changes
Dec 28, 2024
|
|
||
| """ | ||
| print('running LVS...') | ||
| lvs_passed, lvs_log = self.run_lvs(lib_name, cell_name, run_rcx=True) |
There was a problem hiding this comment.
run_rcx should be False in this lvs_cell() method, since this is for LVS only. extract_cell() should be used for run_rcx=True.
| raise ValueError(f'LVL failed... log file: {lvl_log}') | ||
|
|
||
| def nvn_cell(self, cell_name: str, netlist: str, ref_file: str) -> None: | ||
| """Run netlist-vs-netlist (NVN) on two netlist files. |
There was a problem hiding this comment.
Slight nitpicking on the method names: Ideally these should be the names and implementations:
LVL: should take layout as input and stream out gds for comparing
GVG: should take gds as input
SVS: should take schematic as input and stream out netlist for comparing
NVN: should take netlist as input
So the NVN method is correctly named, but the LVL should be GVG. Alternatively you could do something similar to lvs_cell() and lvs_cell_raw(). But it's ok to keep the names as-is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_netlistThis PR is part of breaking up PR #34.
Comment here about renaming files has been addressed.
CDL conflict discussed here is un-addressed. I will open a separate issue for this.