fix: Ability needs PartialOrd, not Ord #129
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(as far as I understand)
Abilities can be compared, but aren't necessarily related. Nor do they have a 'total order'
Description
Given my simple example, where abilities have no hierarchy/relation:
Ord
would require me to do this hack, pretending an ability isLess
, which only works because Abilities are currently only compared via>=
.Correct, I think, would be
PartialOrd
:Of course, introducing hierarchy still works.
Type of change
Test plan (required)
I
cargo buil[t]
andcargo test[ed]
💁