Feat/jenkins #238
Open
Feat/jenkins #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all driver calls in favor of fixtures that call the driver methods. This puts all the driver instances at a single point of failure/success and makes them easy to interchange. - Cleanup multi-line quotes to use double quotes
Re-arranged how things are set up and fixtures are imported/created, to avoid re-creating of database tables. When a database driver is instantiated it automagically goes through the process of creating tables and running through all the migration steps, because the schema version is set to 1 on a new database.
bulk get query was not closing the session properly which caused postgres to lock before the teardown step of the index_driver pytest fixture. This made the tests hang indefinitely. Minor cleanups.
- split schema and data migration into two steps - test only data migration - make index_metadata migration happen before urls_metadata step
- migration_12 is fully sql - add more tests to test migration
feat(GP-13): relax update constraint
- Update migrate_12 to include things beyond did<ff
The migration script just instantiates the index driver with auto_migrate=True. The init function of the driver runs through all the migrations.
- Removed unnecessary semicolons in sql statements. - Removed dead imports/variables/functions. - release_number is None on separation from metadata dict. - Separate list equivalence into separate function. - Remove urls from function signatures. - Remove database index on did (from did+url composite key). - Revert reorder of database columns on index_record_metadata table. - Simplified python dictionary pop with default value. - Replace state and type contains check with equal check. - Fix update function to include release_number updates from metadata dict. - Remove base_version table from test setups. - Add more testing on urls_metadata.
- update hash code duplicated on merge, remove duplicate - split up update test into individual fields
- Make sure the update test checks to see the release number is no longer in the metadata jsonb column of the database.
- more dictionary pops for metadata/release_number - make getting urls metadata more unified across functions
…ions [CHORE] Loosen Dependency Requirements
chore(deps): bump deps
chore(release): 2.3.0 alpha
chore(version): version 2.3.0
chore(release): Sam-I-Am Release
DEV-46 fix _stats endpoint. add unit tests
Use the new base Docker images. Remove extra steps for cloning dependencies outside the Docker build since indexd does not currently depend on any private repos. Pin a full set of dependencies using pip-compile. Make tox friendlier for Mac/Homebrew users.
* DEV-159 add pre-commit and detect-secrets Add pre-commit and detect-secrets so it starts to automatically detect secrets for this code base. pre-commit requires cfgv. Use old cfgv version to work with py35 and py27 * DEV-159 add baseline Add baseline file for detect-secrets for future reference. * DEV-159 update readme Update toc. * DEV-159 correct README.md and dev-requirements correct files based on Phil's comment
Add the indexd bin scripts as "scripts" in setup.py, such that installing indexd adds those scripts to the PATH. Ship all such scripts in the Docker image. Make it possible to run indexd_admin.py and migrate_indexd.py using the container image again. Note, however, that they are now assumed to be part of the PATH and are not available at their former location in the /indexd directory. Require virtualenv >= 20.0.21 when running tox, to ensure virtualenv will come with at least the same minimum pip version already specified. Fix random travis build failures seemingly caused by tox using and old version of pip that can't handle PEP 508 URL dependencies. Make whitespace in tox.ini more consistent.
* DEV-315 update version of jsonschema The version of jsonschema was limited to 2.x. This was causing problems with sheepdog when trying to compile dev dependencies. This repo still supports py2 and py3. Running pip-compile under py2 adds some py2-only dependencies. I had to add manual edits to prevent them from being installed when using py3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description about what this pull request does.
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes