Harvard Dataverse file retriever implementation for Heal SDK #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrsenkow
changed the title
piotrsenkow
changed the title
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
piotrsenkow
changed the title
mfshao
reviewed
Jan 13, 2025
| This module includes an external file retriever function intended to be called | ||
| by the external_files_download module in the Gen3-SDK. | ||
|
|
||
| The retriever function sends requests to the Syracuse QDR API for downloading studies or files. |
There was a problem hiding this comment.
There are many places in this file that is referencing to Syracuse QDR or QDR, which should be replaced by Harvard Dataverse
| return completed | ||
|
|
||
|
|
||
| def download_from_url( |
There was a problem hiding this comment.
this function (any many other functions in this file) are identical to their siblings in the QDR retriever code, we should move them to a shared utils.py module and use from there to reduce code reduncency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: HP-1648
New Features
Nearly identical to the QDR File retriever, this heal sdk function, get_harvard_dataverse_files(), parses a list of metadata hosted in harvard dataverse, utilizing the same dataverse api that QDR adopted.
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes