(PXP:8581): Add apiEndpoint and other arguments to configure to avoid breaking changes
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
|
|
||
| if profile_title in lines: | ||
| profile_line_index = lines.index(profile_title) | ||
| next_profile_index = len(lines) | ||
| for i in range(profile_line_index, len(lines)): | ||
| for i in range(profile_line_index + 1, len(lines)): |
There was a problem hiding this comment.
how come the unit tests didn't catch these 2 issues? 🤔 is there a test case we should add?
There was a problem hiding this comment.
That's a good point. Let me see where did I miss it. Will get back to you on this! 👍
There was a problem hiding this comment.
Ahh! It wasn't really about a missing test case but more about how the test was written. I skipped a step while arranging the test scenario. Will push the update now.
paulineribeyre
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-8581
Bug Fixes
gen3/configwas buggy. This PR Fixes it.Improvements