Fix/metadata missing tags #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
…k-python into fix/metadata_missing_tags
…k-python into fix/metadata_missing_tags
…k-python into fix/metadata_missing_tags
k-burt-uch
requested changes
Apr 11, 2024
| num_tags, len(guid_discovery_metadata.get("tags", [])) | ||
| ) | ||
| tgs = guid_discovery_metadata.get("tags", []) | ||
| num_tags = max(num_tags, 0 if tgs is None else len(tgs)) |
There was a problem hiding this comment.
tgs will never be None since guid_discovery_metadata.get("tags", []) has [] as the default return if guid_discovery_metadata["tags"] is None.
So tgs will always be an array here. This is effectively the same as the change that existed. I would revert this portion of the changeset.
Co-authored-by: burtonk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes