DCF-1384: New DRS fields #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
MaribelleHGomez
force-pushed
the
feat/DCF-1384-gen3index-new-drs-fields
branch
3 times, most recently
from
41cc37e to
9294c8d
Compare
MaribelleHGomez
force-pushed
the
feat/DCF-1384-gen3index-new-drs-fields
branch
from
d07f3c0 to
9294c8d
Compare
BinamB
reviewed
Feb 9, 2024
Comment on lines
-433
to
+454
| return rec.to_json() | ||
| raise_for_status_and_print_error(resp) | ||
|
|
||
| return resp.json() |
There was a problem hiding this comment.
Why change from to_json() to json()?
| @@ -229,3 +229,52 @@ def test_blank(gen3_index): | |||
| # delete the record | |||
| drec = gen3_index.delete_record(updatedblank["did"]) | |||
| assert drec._deleted | |||
|
|
|||
|
|
|||
| def test_desc_and_content_dates(gen3_index): | |||
There was a problem hiding this comment.
Can you add a test where these fields are not provided?
BinamB
previously approved these changes
Feb 26, 2024
MaribelleHGomez
force-pushed
the
feat/DCF-1384-gen3index-new-drs-fields
branch
from
1fb3b73 to
c235963
Compare
BinamB
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-1384
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes