Add CI to docs + Password protect pages #287
Conversation
jawadqur
force-pushed
the
feat/staging-docs
branch
from
383b894 to
23fb23c
Compare
jawadqur
force-pushed
the
feat/staging-docs
branch
from
23fb23c to
e6afc9e
Compare
| - stylesheets/extra.css | ||
| - encryptcontent: | ||
| password_inventory: | ||
| _global: 'gen3' |
There was a problem hiding this comment.
I realize this isn't necessarily intended to be secure, but having this plain text sorta defeats the purpose of trying to hide the content on the branches. I think this needs to be a real Github secret
There was a problem hiding this comment.
This is just so that random people don't run into it for now, until we're ready to publish.
There was a problem hiding this comment.
Yeah but the repo is public so anyone can see this. So long as it's well understood that this isn't actually protecting against anything and folks writing the documentation understand that this does not actually prevent anyone from seeing the content, then it's okay. But configuring a secret on the repo and using that as a var here isn't too complicated and would alleviate my concern entirely
There was a problem hiding this comment.
Yeah, the intention behind this password is for crawlers not to index this page, not to hide the content from the public.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes