feat(gen3-module): Updated gen3 module to improve deployment experience

uc-cdis · Jun 11, 2024 · 9406d7c · 9406d7c
1 parent ae07c20
commit 9406d7c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tf_files/gen3/service-accounts.tf b/tf_files/gen3/service-accounts.tf
@@ -576,7 +576,7 @@ resource "aws_iam_role_policy" "aws-load-balancer-role-policy" {
 }
 
 resource "aws_iam_role" "external-secrets-role" {
-  count = var.namespace == "default" ? 1 : 0
+  count = var.namespace == "default" || var.deploy_external_secrets  ? 1 : 0
   name = "${var.vpc_name}-${var.namespace}-external-secrets-sa"
   description = "Role for external-secrets service account for ${var.vpc_name}"
   assume_role_policy = jsonencode({
@@ -612,7 +612,7 @@ resource "aws_iam_role" "external-secrets-role" {
 }
 
 resource "aws_iam_role_policy" "external-secrets-role-policy" {
-  count = var.namespace == "default" ? 1 : 0
+  count = var.namespace == "default" || var.deploy_external_secrets ? 1 : 0
   name = "external-secrets-role-policy"
   role = aws_iam_role.external-secrets-role[0].id
 

diff --git a/tf_files/gen3/variables.tf b/tf_files/gen3/variables.tf
@@ -55,6 +55,12 @@ variable "dd_enabled" {
   default     = false
 }
 
+variable "deploy_external_secrets" {
+  description = "Deploy external secrets"
+  type        = bool
+  default     = false
+}
+
 variable "dictionary_url" {
   description = "URL to the data dictionary"
   default     = ""