Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the register form to assume DUA consent. #1149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −0
Open

Modify the register form to assume DUA consent. #1149

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f04b732
Modify the register form to assume DUA consent.
frankliuao May 23, 2024
aba6f46
Add href to DUA generic link
frankliuao May 23, 2024
3ef1879
Editing wording and agreement location
frankliuao May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fence/templates/register_user.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ <h1>{% block title %}Register{% endblock %}</h1>
{% block content %}
paulineribeyre marked this conversation as resolved.
Show resolved Hide resolved
<form method="post">

<h1 class="introduction">Register in order to get access to download data</h1>
<h1 class="introduction">Register* in order to get access to download data</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the asterisk?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment to register.
Comment in <p>.

Copy link
Contributor

@paulineribeyre paulineribeyre May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asterisks make sense when they refer to something else - the paragraph would need to start with an asterisk as well

but here i don't think it's necessary at all, the text is right next to the submit button and visible enough

although it might be better above the button? so you read it before you click submit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Edited.

{{ form.csrf_token }}
<ul>
<li> {{ form.firstname.label }} {{ form.firstname }} </li>
Expand All @@ -30,6 +30,7 @@ <h1 class="introduction">Register in order to get access to download data</h1>
</li>
</ul>
<button class="button-primary-orange" type="submit">Register</button>
<p>By registering and submitting this form, you hereby acknowledge and consent to be bound by our terms and conditions, and our data use agreement (DUA), both of which can be found on our main website, or on our <a href="/dashboard/Public/documentation/DUA.html">data access portal</a>. </p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link directly to the terms and conditions as well? i don't see where the link is on the portal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some terms and conditions are on our main website (www.midrc.org) so it's hard to find a generic url for it. It'll add MIDRC-specific contents to this page which is what I'm trying to avoid. I just checked and I think DUA itself is fine. I've modified it so it only says DUA.

</form>
{% endblock %}

Expand Down
Loading