Skip to content

Commit

Permalink
update to reflect Pauline's recommendations
Browse files Browse the repository at this point in the history
  • Loading branch information
smvgarcia committed Mar 15, 2024
1 parent 788bebd commit 61fce08
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
11 changes: 8 additions & 3 deletions docs/nextflow-create-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gen3 offers a collection of FedRAMP security-compliant base images. Building on

You can access these images on on Quay.io, a repository site for Docker images:

[https://quay.io/repository/cdis/containers?tab=tags&tag=latest](https://quay.io/repository/cdis/containers?tab=tags&tag=latest)
[https://quay.io/repository/cdis/containers?tab=tags](https://quay.io/repository/cdis/containers?tab=tag)

### How to choose your base image

Expand All @@ -32,6 +32,7 @@ Some tools you may be using in your workflow can take advantage of GPU capacity
We have 2 images in our current selection that offer [CUDA](https://www.turing.com/kb/understanding-nvidia-cuda) support for running on GPUs -- these have "cuda" in the image name, followed by the CUDA version. When possible, please choose the latest version of CUDA compatible with your tools.

> gen3-cuda-12.3-ubuntu22.04-openssl *(preferred)*
>
> gen3-cuda-11.8-ubuntu22.04-openssl *(only use if your tools require a lower version of CUDA)*
**CPU images**
Expand Down Expand Up @@ -78,7 +79,7 @@ Once you are signed in to Docker, you can run the command they suggest after pul

You can run the next suggested command (shown in red box above, `docker scout cves...`) to see the full list of vulnerabilities.

Images will be able to pass Gen3 security scanning if there are no Critical or High vulnerabilities, and **[add something about CVSS?]**
Images should be able to pass Gen3 security scanning if there are no Critical vulnerabilities.

*Want to know more about Docker Scout? [Check out the documentation](https://docs.docker.com/scout/quickstart/).*

Expand All @@ -98,7 +99,11 @@ In our example here, we will have you build your image using a `requirements.txt

Our example will use the files in the [torch_cuda_test directory](https://github.com/uc-cdis/bio-nextflow/tree/master/nextflow_notebooks/containerized_gpu_workflows/torch_cuda_test) of the bio-nextflow repository. You can review the `readme` file in this directory for more information. It is a simple example that will build up from our base image by adding PyTorch. The Nextflow script will ultimately use a python script that checks the version of CUDA in the GPU instance and checks whether it is compatible with the version of PyTorch and CUDA available in the container.

First, in the terminal, navigate to the directory where the downloaded Dockerfile and requirements.txt are located.
First, in the terminal, navigate to the directory where you cloned the the `bio-nextflow` repository (see [Prerequisites section](#prerequisites)). Next, navigate to where the downloaded Dockerfile and requirements.txt are located:

>>>
cd bio-nextflow/nextflow_notebooks/containerized_gpu_workflows/torch_cuda_test
>>>
> Note that the first line of the Dockerfile references the fetch tag for one of our GPU base images. This is always how you will reference a base image -- with `FROM` and the Dockertag.
Expand Down
2 changes: 1 addition & 1 deletion docs/nextflow-upload-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Before you can push your Docker image to the ECR repository, you need to configu
### Verify configuration:

Run `aws sts get-caller-identity` to verify that your CLI is using the temporary credentials.
Run `aws sts get-caller-identity` to verify that your CLI is using the temporary credentials. If you successfully set the variables, you should see output showing the AWS information - UserID, account, etc.

### Authenticate Docker to ECR

Expand Down

0 comments on commit 61fce08

Please sign in to comment.