Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for heal admin portal #87

Merged
merged 2 commits into from
May 1, 2024

Conversation

urvi-occ
Copy link
Contributor

@urvi-occ urvi-occ commented Apr 30, 2024

New Features

Changes for Heal and BMH admin portal

  • The name of the key changed from brh_data to pp_data

Bug Fixes

  • Fixed error for request response, it was showing error in console that line response.body[0]["Message"]["statusCode"] wasn't able to find statusCode

Improvements

  • Added updateRedirectHome for Direct Pay Form

@@ -54,7 +54,7 @@ const DirectPayForm = (props) => {
var data = {
"queryStringParameters": {
"method": "confirmBillingID",
"brh_data": {
"pp_data": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change affects the instance that currently deployed in BRH?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I wanted to go with the generic name for both BRH and Heal so Changes are needed on both. Currently, this is on Dev, once we move Heal to Production, These changes should be made on BRH and Heal Production Workspace Admin Env

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briennal @nss10 for your awareness

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and @urvi-occ just to confirm, even though this change will affect BRH in the future, it will not break BRH now right? Since I assume the prod backend that BRH is pointing to is still expecting the old data format?

Copy link
Contributor Author

@urvi-occ urvi-occ May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would not break the BRH Production currently, but Dev BRH would not work without these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarfying, I'll merge this and deploy to qa-heal momentarily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mfshao mfshao merged commit 938aa0c into uc-cdis:master May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants