Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extended] update-automation to rockcraft.yaml #635

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

rudra-iitm
Copy link
Contributor

  • Rockcraft is the tool for building Ubuntu-based and production-grade OCI images, aka rocks!
  • Using the same language as Snapcraft and Charmcraft, Rockcraft offers a truly declarative way for building efficient container images.
  • Rockcraft Docs - https://documentation.ubuntu.com/rockcraft/en/latest/

@rudra-iitm
Copy link
Contributor Author

@sergio-costas , Could you kindly assess and provide feedback on this pull request?

Copy link
Collaborator

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some change requests.

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
updatesnap/updatesnapyaml.py Outdated Show resolved Hide resolved
@rudra-iitm
Copy link
Contributor Author

@sergio-costas, pls review the changes

Copy link
Collaborator

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nitpick.

updatesnap/updatesnapyaml.py Show resolved Hide resolved
Copy link
Collaborator

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good.

@sergio-costas sergio-costas merged commit 5c54c95 into ubuntu:stable Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants