Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect uses of the term "challenge" #747

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Jan 22, 2025

Depending on the context, we now use either "secret" or "password".

UDENG-5180

@adombeck adombeck force-pushed the UDENG-5180-fix-incorrect-uses-of-challenge branch 2 times, most recently from 0cd5c01 to 3b9733d Compare January 22, 2025 11:16
@adombeck
Copy link
Contributor Author

Only unrelated test failures

@adombeck adombeck marked this pull request as ready for review January 22, 2025 12:10
@adombeck adombeck requested a review from a team as a code owner January 22, 2025 12:10
@adombeck adombeck requested a review from 3v1n0 January 23, 2025 11:07
@adombeck adombeck force-pushed the UDENG-5180-fix-incorrect-uses-of-challenge branch from 0a8f2fc to 878ce45 Compare January 24, 2025 17:26
@adombeck
Copy link
Contributor Author

Rebased on main and resolved the conflicts

@adombeck adombeck requested a review from 3v1n0 January 24, 2025 17:26
adombeck and others added 2 commits January 25, 2025 00:00
Depending on the context, we now use either "secret" or "password".
@adombeck adombeck force-pushed the UDENG-5180-fix-incorrect-uses-of-challenge branch from 878ce45 to 8e0c7c7 Compare January 24, 2025 23:00
@adombeck adombeck merged commit e06c664 into main Jan 24, 2025
9 of 11 checks passed
@adombeck adombeck deleted the UDENG-5180-fix-incorrect-uses-of-challenge branch January 24, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants