Allow importing log package #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
UDENG-5773-allow-importing-log-package
branch
from
659269a to
31fcc8e
Compare
|
Moved to the top-level as suggested in #626 (comment) (to avoid starting the discussion about using |
1 task
didrocks
approved these changes
Jan 14, 2025
pam/pam.go
Outdated
| } | ||
| journal.Print(journalPriority, format, args...) | ||
| }) | ||
| log.InitJournalHandler(true) |
There was a problem hiding this comment.
Maybe a comment on why we force connecting to the journal? (I think this is self-explanatory for now as we now we are in the PAM module, but I think being explicit can be beneficial in the future).
There was a problem hiding this comment.
Added a comment in #720
adombeck
force-pushed
the
UDENG-5773-allow-importing-log-package
branch
from
31fcc8e to
fcbcb98
Compare
To allow importing it in the broker repo
adombeck
force-pushed
the
UDENG-5773-allow-importing-log-package
branch
from
fcbcb98 to
fc21d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #720, merge after that
Move log package out of
internal/to allow importing it in the broker repo.UDENG-5773